Skip to content

[3.14] gh-141174: Improve annotationlib._Stringifier test coverage (GH-141220) #141358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

[3.14] gh-141174: Improve annotationlib._Stringifier test coverage (GH-141220) #141358

merged 1 commit into from
Nov 10, 2025

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 10, 2025 •
edited by bedevere-app bot
Loading

  • Test _Stringifier.__convert_to_ast() for containers

  • Test partial evaluation of ForwardRefs in _Stringifier
    (cherry picked from commit 55ea132)

Co-authored-by: dr-carlos 77367421+dr-carlos@users.noreply.github.com

@dr-carlos @miss-islington
pythongh-141174: Improve annotationlib._Stringifier test coverage (p…
f58915c 
…ythonGH-141220)

* Test `_Stringifier.__convert_to_ast()` for containers

* Test partial evaluation of `ForwardRef`s in `_Stringifier`
(cherry picked from commit 55ea13231313a2133e6f5a6112409d349081f273)

Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this pull request Nov 10, 2025
Merged
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Nov 10, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 10, 2025
Open
@JelleZijlstra JelleZijlstra enabled auto-merge (squash) November 10, 2025 14:57
@dr-carlos
Copy link
Contributor

dr-carlos commented Nov 10, 2025 •
edited
Loading

Not sure why this PR is failing iOS builds? The error is

xcodebuild: error: Unable to find a device matching the provided destination specifier:
  		{ platform:iOS Simulator, OS:18.5, name:iPhone 16e }
  
  	The requested device could not be found because no available devices matched the request.

Which seems entirely unrelated to this PR - probably either a GitHub Actions issue or it just needs a re-run.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Nov 10, 2025

Yeah I am retrying it.

@JelleZijlstra JelleZijlstra merged commit 462e225 into python:3.14 Nov 10, 2025
86 of 88 checks passed
@mhsmith
Copy link
Member

mhsmith commented Nov 11, 2025

@freakboy3742: Is this the same as actions/runner-images#12777? The error message looks different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @dr-carlos @JelleZijlstra @mhsmith