Skip to content

Fix assertions regarding magic methods function body that was not executed #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lisroach merged 1 commit into from
Sep 9, 2019
Merged

Fix assertions regarding magic methods function body that was not executed #14154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions Lib/unittest/test/testmock/testasync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,17 +361,14 @@ def test_add_side_effect_iterable(self):


class AsyncContextManagerTest(unittest.TestCase):

class WithAsyncContextManager:
def __init__(self):
self.entered = False
self.exited = False

async def __aenter__(self, *args, **kwargs):
self.entered = True
return self

async def __aexit__(self, *args, **kwargs):
self.exited = True
pass

def test_magic_methods_are_async_mocks(self):
mock = MagicMock(self.WithAsyncContextManager())
Expand All @@ -390,11 +387,7 @@ async def use_context_manager():
return result

result = asyncio.run(use_context_manager())
self.assertFalse(instance.entered)
self.assertFalse(instance.exited)
self.assertTrue(called)
self.assertTrue(mock_instance.entered)
self.assertTrue(mock_instance.exited)
self.assertTrue(mock_instance.__aenter__.called)
self.assertTrue(mock_instance.__aexit__.called)
self.assertIsNot(mock_instance, result)
Expand Down