gh-141648: Fix clearing of executors #141649
Open
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
markshannon
requested changes
Nov 17, 2025
| Py_DECREF(e); | ||
| executor->exits[i].executor = NULL; | ||
| if (e != cold && e != cold_dynamic) { | ||
| executor_clear((PyObject *)e); |
Member
There was a problem hiding this comment.
Suggested change
| executor_clear((PyObject *)e); | |
| Py_DECREF(e); |
Using executor_clear could clear a live executor.
Member
Author
There was a problem hiding this comment.
Py_DECREF doesn't work
The problem is that executors must be forcefully cleared upon invalidation, otherwise their reference cycles prevent clearing of invalid executors and those remain in the bytecode.
Member
Author
There was a problem hiding this comment.
Also executor_clear will never clear a live executor --- executor_clear only, unlinks, detaches, and decrefs an executor, it doesn't call PyObject_GC_DEL on it.
|
When you're done making the requested changes, leave the comment: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't produce a test case. Would appreciate if someone can do so.
The problem is that executors must be forcefully cleared upon invalidation, otherwise their reference cycles prevent clearing of invalid executors and those remain in the bytecode.