Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 17, 2025

(cherry picked from commit df8091d)

Co-authored-by: Tamzin Hadasa Kelly tk.infinity@gmail.com


📚 Documentation preview 📚: https://cpython-previews--141654.org.readthedocs.build/

pythonGH-141652)

(cherry picked from commit df8091d)

Co-authored-by: Tamzin Hadasa Kelly <tk.infinity@gmail.com>
@python-cla-bot
Copy link

python-cla-bot bot commented Nov 17, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@hugovk
Copy link
Member

hugovk commented Nov 17, 2025

@TamzinHadasa
Copy link
Contributor

@hugovk I never make commits from that email address, which is just my go-to "send spam here" Gmail from childhood. I'm happy to re-sign the CLA with it if that's necessary, but wouldn't want that to be the commit email of record. Do I need to change something in my GitHub account settings?

@hugovk
Copy link
Member

hugovk commented Nov 17, 2025

GitHub already used the email from your account when the original PR was squashed. We can confirm by running:

git show df8091d516f874bd8222569794229ea77fb3a0a3

Or looking at:

https://github.com/python/cpython/commit/df8091d516f874bd8222569794229ea77fb3a0a3.patch

Yes, it is necessary to sign the CLA with that email to be able to merge these backports, and it doesn't change that this email was already used for the original squash-merge.

You can change your GitHub settings if you want, which would affect what address is used for squash-merged commits in the future.

(Personally I use the private @users.noreply.github.com email locally and via the GitHub settings.)

@hugovk hugovk merged commit eeb5fbf into python:3.14 Nov 17, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 17, 2025
@TamzinHadasa
Copy link
Contributor

Huh. Well I'll look into that on my end. Signed now. 🙂

@hugovk
Copy link
Member

hugovk commented Nov 17, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants