-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
gh-141671: PyMODINIT_FUNC: apply __declspec(dllexport) on Windows
#141672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| #if defined(_WIN32) || defined(__CYGWIN__) | ||
| #if defined(Py_ENABLE_SHARED) | ||
| #if !defined(Py_BUILD_CORE) || defined(Py_ENABLE_SHARED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure about this... don't we need it for our own exports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for Py_ENABLE_SHARED -- see #99888 that added the #else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see we do these checks again everywhere else we use the macros. No problem them.
|
TBH, I have no view. My knowledge of C is very out of date, so I wouldn't trust anything I might say anyway... |
|
The (Edit: admittedly we also aren't the people that it's designed to help either) |
PyMODINIT_FUNCdoes not apply__declspec(dllexport)on Windows #141671