Skip to content

Conversation

@cmaloney
Copy link
Contributor

@cmaloney cmaloney commented Nov 19, 2025

Missed the free threading tests in initial implementation. Running the test under thread sanitizer on a free-threaded build didn't find any issues.

Missed the free threading tests in initial implementation. Running the
test under thread sanitizer on a free-threaded build didn't find any issues.
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Nov 19, 2025
@cmaloney cmaloney added skip news needs backport to 3.14 bugs and security fixes labels Nov 19, 2025
@kumaraditya303 kumaraditya303 merged commit 019c315 into python:main Nov 21, 2025
56 checks passed
@miss-islington-app
Copy link

Thanks @cmaloney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @cmaloney and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 019c315a8e52978da67a3108e441ed5ee376f504 3.14

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 019c315.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/12743) and take a look at the build logs.
  4. Check if the failure is related to this commit (019c315) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/12743

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 847, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

@cmaloney cmaloney deleted the gh129559_ft branch November 21, 2025 23:00
@bedevere-app
Copy link

bedevere-app bot commented Nov 22, 2025

GH-141835 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 22, 2025
cmaloney added a commit to cmaloney/cpython that referenced this pull request Nov 22, 2025
… free-threading (pythonGH-141739)

(cherry picked from commit 019c315)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
kumaraditya303 pushed a commit that referenced this pull request Nov 22, 2025
…threading (GH-141739) (#141835)

[3.14] gh-129559: add `bytearray.resize` thread safety test for free-threading  (GH-141739)
(cherry picked from commit 019c315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants