gh-141865: Allow 'deprecated-removed' message to be translated #141867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zware
commented
Nov 23, 2025
| "deprecated-removed:: second argument cannot be `next`" | ||
| ) | ||
| self.arguments[0] = version_deprecated, version_removed | ||
| self.arguments[0] = TerribleHashableDictHack( |
Member
Author
There was a problem hiding this comment.
Another option that avoids this hack is to check the order of {deprecated} and {removed} in the string, adjust the order of the tuple accordingly, and replace each placeholder with %s. That precludes the possibility of a translation needing to repeat either placeholder, but I don't know if that's a realistic need.
Note that the not-a-dict hack is necessary for this route due to dict not being hashable, raising a SphinxParallelError.
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Slightly simpler fix: #141865 (comment)
Member
|
Closing in favour of #141882. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--141867.org.readthedocs.build/