gh-141865: Fix translation of strings in changes.py extension
#141882
Conversation
hugovk
added
skip news
needs backport to 3.13
|
Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…pythonGH-141882) (cherry picked from commit 4fe6e81) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-141883 is a backport of this pull request to the 3.14 branch. |
…pythonGH-141882) (cherry picked from commit 4fe6e81) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-141884 is a backport of this pull request to the 3.13 branch. |
| {% trans %}Deprecated since version {deprecated}, will be removed in version {removed}{% endtrans %} | ||
| {% trans %}Deprecated since version {deprecated}, removed in version {removed}{% endtrans %} | ||
| {% trans %}Deprecated since version %s, will be removed in version %s{% endtrans %} | ||
| {% trans %}Deprecated since version %s, removed in version %s{% endtrans %} |
There was a problem hiding this comment.
This precludes the possibility of a translation that needs to reorder the clauses. Not being a linguist I'm not certain that that's a necessity, but it seems well within the realm of possibility.
There was a problem hiding this comment.
It may be a possibility, however it may also be unnecessary. I think we should keep this simple fix for now, and if someone complains look into the hacky options.
There was a problem hiding this comment.
I went through the languages on TX for the string, and all of them have the expected order.
3 participants
📚 Documentation preview 📚: https://cpython-previews--141882.org.readthedocs.build/