gh-141518: Add PyUnstable_InterpreterFrame_GetFrameObject() function #141950
+89
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction Add also PyUnstable_InterpreterFrame type.
vstinner
requested review from
AA-Turner,
ZeroIntensity,
ericsnowcurrently and
markshannon
as code owners
Member
Author
|
See #141665 (review) for the rationale on adding this function. |
emmatyping
reviewed
Nov 26, 2025
| The interpreter's internal frame representation. | ||
| The structure is intentionally opaque and there are currently no plans to |
Member
There was a problem hiding this comment.
Suggested change
| The structure is intentionally opaque and there are currently no plans to | |
| The structure is intentionally opaque, and there are currently no plans to |
| PyAPI_FUNC(int) PyUnstable_InterpreterFrame_GetLine(struct _PyInterpreterFrame *frame); | ||
| PyAPI_FUNC(int) PyUnstable_InterpreterFrame_GetLine( | ||
| PyUnstable_InterpreterFrame *frame); | ||
|
|
Member
There was a problem hiding this comment.
Maybe it'll be better to add inline comment from docs?
| @@ -0,0 +1,2 @@ | |||
| Add :c:func:`PyUnstable_InterpreterFrame_GetFrameObject` to get a frame | |||
| object from an interpreter frame. Patch by Victor Stinner. | |||
Member
There was a problem hiding this comment.
Should we mention renaming of _PyInterpreterFrame into PyUnstable_InterpreterFrame?
And in the whatsnew file.
| return frame_generator_get((PyObject *)frame, NULL); | ||
| } | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Adding two blank lines is intentional, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add also PyUnstable_InterpreterFrame type.
PyUnstable_InterpreterState_SetEvalFrameFunc()#141518📚 Documentation preview 📚: https://cpython-previews--141950.org.readthedocs.build/