Skip to content

gh-142163: Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE is set #142164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2025
Merged

gh-142163: Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE is set #142164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9161899
Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE is set.
ZeroIntensity Dec 1, 2025
fe4fb52
Add blurb.
ZeroIntensity Dec 1, 2025
2321c5a
Improve blurb.
ZeroIntensity Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Include/pyport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,9 +509,15 @@ extern "C" {
# define Py_CAN_START_THREADS 1
#endif

#ifdef WITH_THREAD
// HAVE_THREAD_LOCAL is just defined here for compatibility's sake

/* gh-142163: Some libraries rely on HAVE_THREAD_LOCAL being undefined, so
* we can only define it only when Py_BUILD_CORE is set.*/
#ifdef Py_BUILD_CORE
// This is no longer coupled to _Py_thread_local.
# define HAVE_THREAD_LOCAL 1
#endif

#ifdef WITH_THREAD
# ifdef thread_local
# define _Py_thread_local thread_local
# elif __STDC_VERSION__ >= 201112L && !defined(__STDC_NO_THREADS__)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/C_API/2025-12-01-18-17-16.gh-issue-142163.2HiX5A.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix the ``HAVE_THREAD_LOCAL`` macro being defined without the
``Py_BUILD_CORE`` macro set after including :file:`Python.h`.
Loading