Skip to content

Document None for timeout argument of select.select #142177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

Document None for timeout argument of select.select #142177

merged 1 commit into from
Dec 2, 2025
+2 −2

Conversation

@encukou
Copy link
Member

@encukou encukou commented Dec 2, 2025 •
edited by hugovk
Loading

See https://github.com/python/cpython/pull/142176/files
If we rely on None being equivalent to omitting the argument, we should document it.

📚 Documentation preview 📚: https://cpython-previews--142177.org.readthedocs.build/

@encukou encukou requested a review from hugovk December 2, 2025 08:25
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Dec 2, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Dec 2, 2025
@encukou encukou mentioned this pull request Dec 2, 2025
Closed
@hugovk hugovk merged commit 748c4b4 into python:main Dec 2, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Dec 2, 2025
@encukou encukou deleted the select-doc-none branch December 2, 2025 11:09
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 2, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2025

Thanks @encukou for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2025

Thanks @encukou for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2025

Sorry, @encukou and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 748c4b47b70f89cb132f865250eb6c951a177366 3.13

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2025

Sorry, @encukou and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 748c4b47b70f89cb132f865250eb6c951a177366 3.14

encukou added a commit to encukou/cpython that referenced this pull request Dec 2, 2025
@encukou
[3.14] Document None for timeout argument of select.select (pythonGH-…
d1d5047 
…142177)

(cherry picked from commit 748c4b4)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2025

GH-142182 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 2, 2025
hugovk pushed a commit that referenced this pull request Dec 2, 2025
@encukou
[3.14] Document None for timeout argument of select.select (GH-142177) (
82274c4 
#142182)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2025
@encukou @miss-islington
[3.14] Document None for timeout argument of select.select (pythonGH-…
b49ec08 
…142177) (pythonGH-142182)

(cherry picked from commit 82274c4)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2025

GH-142187 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 2, 2025
encukou added a commit that referenced this pull request Dec 2, 2025
@miss-islington @encukou
[3.13] Document None for timeout argument of select.select (GH-142177)
caf1794 
cherry picked from commit 82274c4 (GH-142182)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk Awaiting requested review from hugovk

Assignees

@hugovk hugovk

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou @hugovk