Skip to content

GH-139862: Fix direct instantiation of HelpFormatter #142384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 3 commits into from
Dec 7, 2025
Merged

GH-139862: Fix direct instantiation of HelpFormatter #142384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b1975b
Initialize set_color as false in the HelpFormatter
savannahostrowski Dec 7, 2025
e6334f1
Merge branch 'main' into fix-help-format-color
savannahostrowski Dec 7, 2025
c04ba18
Add regression test for direct instantiation of HelpFormatter
savannahostrowski Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ def __init__(
self._whitespace_matcher = _re.compile(r'\s+', _re.ASCII)
self._long_break_matcher = _re.compile(r'\n\n\n+')

self._set_color(False)

def _set_color(self, color):
from _colorize import can_colorize, decolor, get_theme

Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5694,6 +5694,11 @@ def custom_formatter(prog):
a-very-long-command command that does something
'''))

def test_direct_formatter_instantiation(self):
formatter = argparse.HelpFormatter(prog="program")
formatter.add_usage(usage=None, actions=[], groups=[])
help_text = formatter.format_help()
self.assertEqual(help_text, "usage: program\n")

# =====================================
# Optional/Positional constructor tests
Expand Down
Loading