gh-142571: Check for errors before calling each syscall in PyUnstable_CopyPerfMapFile()
#142460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
changed the title
PyUnstable_CopyPerfMapFile()
pablogsal
approved these changes
Dec 11, 2025
Member
|
We need a news entry and we can backport it. @AZero13 can you add one? |
AZero13
changed the title
PyUnstable_CopyPerfMapFile()PyUnstable_CopyPerfMapFile()
We should not fflush a file that has not been written to if it fails.
Misc/NEWS.d/next/Core_and_Builtins/2025-12-11-09-06-36.gh-issue-142571.Csdxnn.rst
Outdated
Show resolved
Hide resolved
…e-142571.Csdxnn.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner
reviewed
Dec 11, 2025
Misc/NEWS.d/next/C_API/2025-12-11-09-06-36.gh-issue-142571.Csdxnn.rst
Outdated
Show resolved
Hide resolved
…xnn.rst Co-authored-by: Victor Stinner <vstinner@python.org>
pablogsal
added
needs backport to 3.13
pablogsal
approved these changes
Dec 11, 2025
|
Thanks @AZero13 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 11, 2025
…nstable_CopyPerfMapFile()` (pythonGH-142460) (cherry picked from commit 9fe6e3e) Co-authored-by: AZero13 <gfunni234@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
Sorry, @AZero13 and @pablogsal, I could not cleanly backport this to |
|
GH-142600 is a backport of this pull request to the 3.14 branch. |
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 11, 2025
…in `PyUnstable_CopyPerfMapFile()` (pythonGH-142460) (cherry picked from commit 9fe6e3e) Co-authored-by: AZero13 <gfunni234@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
GH-142602 is a backport of this pull request to the 3.13 branch. |
pablogsal
added a commit
that referenced
this pull request
Dec 11, 2025
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
…nstable_CopyPerfMapFile()` (python#142460) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not fflush a file that has not been written to if it fails.
PyUnstable_CopyPerfMapFilecalls fflush even when the file fails to open. #142571