gh-142468: pdb: Support break/clear filename:function syntax
#142470
+43
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisk
reviewed
Dec 9, 2025
aisk
reviewed
Dec 9, 2025
Misc/NEWS.d/next/Library/2025-12-09-15-18-43.gh-issue-142468.V64wcC.rst
Outdated
Show resolved
Hide resolved
…64wcC.rst Co-authored-by: AN Long <aisk@users.noreply.github.com>
aisk
reviewed
Dec 9, 2025
Co-authored-by: AN Long <aisk@users.noreply.github.com>
aisk
reviewed
Dec 9, 2025
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Contributor
Author
|
If needed, I'll add more test cases later. |
cocolato
changed the title
pdb: Support break filename:function syntaxpdb: Support break/clear filename:function syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
break filename:functionsyntaxrefer: #142468
Description
This PR extends
pdb'sbreakcommand to support thefilename:functionsyntax.Previously, when a colon was present in the argument,
pdbassumed the format wasfilename:lineno. If the part after the colon wasn't an integer, it would raise a "Bad lineno" error.This change modifies
do_breakto catch theValueErrorwhen parsing the line number. If parsing fails, it attempts to resolve the argument as a function name within the specified file usingfind_function.filename:functionsyntax for pdb break and clear command #142468