Skip to content

[3.14] gh-142048: Fix lost gc allocations count on thread cleanup (GH-142233) #142504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 1 commit into from
Dec 10, 2025
Merged

[3.14] gh-142048: Fix lost gc allocations count on thread cleanup (GH-142233) #142504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,16 +1815,23 @@ PyThreadState_Clear(PyThreadState *tstate)
struct _Py_freelists *freelists = _Py_freelists_GET();
_PyObject_ClearFreeLists(freelists, 1);

// Flush the thread's local GC allocation count to the global count
// before the thread state is cleared, otherwise the count is lost.
_PyThreadStateImpl *tstate_impl = (_PyThreadStateImpl *)tstate;
_Py_atomic_add_int(&tstate->interp->gc.young.count,
(int)tstate_impl->gc.alloc_count);
tstate_impl->gc.alloc_count = 0;

// Merge our thread-local refcounts into the type's own refcount and
// free our local refcount array.
_PyObject_FinalizePerThreadRefcounts((_PyThreadStateImpl *)tstate);
_PyObject_FinalizePerThreadRefcounts(tstate_impl);

// Remove ourself from the biased reference counting table of threads.
_Py_brc_remove_thread(tstate);

// Release our thread-local copies of the bytecode for reuse by another
// thread
_Py_ClearTLBCIndex((_PyThreadStateImpl *)tstate);
_Py_ClearTLBCIndex(tstate_impl);
#endif

// Merge our queue of pointers to be freed into the interpreter queue.
Expand Down
Loading