gh-142414: Remove singleton design pattern in _crossinterp.py #142553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note35
force-pushed
the
gh-142414-no-singleton
branch
2 times, most recently
from
d2f7b30 to
445b2d9
Compare
note35
force-pushed
the
gh-142414-no-singleton
branch
from
445b2d9 to
cf6ac24
Compare
Contributor
Author
|
Closed per #142414 (comment) I don't think this can solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with
./python -m test test_interpreters test_struct./python -m test test_interpreters test_structfails with: KeyError: concurrent.interpreters._queues.UNBOUND #142414 (comment) by Victor../python -m test test_interpreters(after adding the Victor's test into this PR)Singleton is removed per suggestion in #142414 (comment)
I also had another PR to keep the singleton: #142515
./python -m test test_interpreters test_structfails with: KeyError: concurrent.interpreters._queues.UNBOUND #142414