-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-142495 fix __missing__ data race condition #142569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca762c7 to
2afea50
Compare
|
Note that someone actually asked on the issue if they could work on it. Please, communicate with them. cc @LindaSummer In addition, read our policy about https://devguide.python.org/getting-started/generative-ai/ (the PR summary looks like AI-generated so I want to be sure that the PR hasn't been so). |
2afea50 to
4310b88
Compare
the test code is generate by llm, the source code is not |
|
Tests shouldn't be written by LLM as they are exactly here to exercise whether the change is correct. In addition, it takes too much to review AI-generated test code so I'm going to close this, sorry. |
The original defdict_missing function in
cpython/Modules/_collectionsmodule.c:2216-2239 had a race
condition where:
fix