Skip to content

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Dec 12, 2025

@Zheaoli
Copy link
Contributor

Zheaoli commented Dec 12, 2025

Should I change #136070 to avoid the refleak?

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: I confirm that this change fix the refleak. I didn't review the change itself, it just looks good to me :-)

$ ./python -m test test.test_multiprocessing_fork.test_threads -R 3:3 
(...)
Result: SUCCESS

@Fidget-Spinner
Copy link
Member Author

Should I change #136070 to avoid the refleak?

The PR can't be fixed/ the code generator won't allow the change until #142604 is merged.

@Fidget-Spinner Fidget-Spinner merged commit a3a611b into python:main Dec 12, 2025
72 checks passed
@Fidget-Spinner Fidget-Spinner deleted the partial_revert_135860 branch December 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants