-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142776: Ensure fp file descriptor is closed on all code paths in import.c #142777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
brettcannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential uninitialized use of fp now.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Oops. Refactored a bit, I believe it's better now. |
brettcannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a news entry?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…de paths in import.c Address review comments and add a NEWS entry
|
@stratakis is this ready to go or did you have more that you wanted to do (you didn't leave the magic comment to signal you were done, although it appears you addressed everything). |
|
Yeah, everything done :) Noting for the squash that I got a fixup commit there, you might not want to add the title of it to the commit message. |
Uh oh!
There was an error while loading. Please reload this page.