Skip to content

gh-142873: Do not check for PyContextVar_CheckExact twice in PyContextVar_Set #142874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 2 commits into from
Dec 17, 2025
Merged

gh-142873: Do not check for PyContextVar_CheckExact twice in PyContextVar_Set #142874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
072aab6
gh-142873: Do not check for `PyContextVar_CheckExact` twice in `PyCon…
sobolevn Dec 17, 2025
47f761c
gh-142873: Do not check for `PyContextVar_CheckExact` twice in `PyCon…
sobolevn Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions Python/context.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,6 @@ PyContextVar_Set(PyObject *ovar, PyObject *val)
ENSURE_ContextVar(ovar, NULL)
PyContextVar *var = (PyContextVar *)ovar;

if (!PyContextVar_CheckExact(var)) {
PyErr_SetString(
PyExc_TypeError, "an instance of ContextVar was expected");
return NULL;
}

PyContext *ctx = context_get();
if (ctx == NULL) {
return NULL;
Expand Down Expand Up @@ -1025,12 +1019,6 @@ static PyObject *
_contextvars_ContextVar_get_impl(PyContextVar *self, PyObject *default_value)
/*[clinic end generated code: output=0746bd0aa2ced7bf input=da66664d5d0af4ad]*/
{
if (!PyContextVar_CheckExact(self)) {
PyErr_SetString(
PyExc_TypeError, "an instance of ContextVar was expected");
return NULL;
}

PyObject *val;
if (PyContextVar_Get((PyObject *)self, default_value, &val) < 0) {
return NULL;
Expand Down
Loading