Skip to content

Conversation

@johnslavik
Copy link
Contributor

@johnslavik johnslavik commented Dec 20, 2025

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say 'unordered' or 'no ordering guarantees'. Please also add the note to rglob().

A

@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@johnslavik
Copy link
Contributor Author

johnslavik commented Dec 20, 2025

I would say 'unordered' or 'no ordering guarantees'. Please also add the note to rglob().

Thanks. Would you also like me to correct the glob module documention to use the same wording?
This is what's in glob docs rn (GH-140184):

.. note::
The pathnames are returned in no particular order. If you need a specific
order, sort the results.

@johnslavik
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2025

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from AA-Turner December 20, 2025 19:48
@AA-Turner
Copy link
Member

Oh, fine: in that case just reuse the exact wording (ie drop 'akin' etc)

A

@johnslavik
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2025

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

@johnslavik johnslavik requested a review from AA-Turner December 20, 2025 21:28
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unless @barneygale has any comments, will merge in a few days.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants