gh-142368: Fix transient error handling in inspection tests #143093
Merged
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for external inspection were failing intermittently on ppc64le and s390x platforms due to UnicodeDecodeError and RuntimeError when reading from live processes. The _check_exception_status method had no exception handling at all, and _get_frames_with_retry was missing UnicodeDecodeError from its suppressed exceptions. Added TRANSIENT_ERRORS tuple to consolidate the exceptions that can occur when reading process memory, and RETRY_DELAY constant to unify sleep intervals. Both affected methods now properly catch all transient errors and retry, matching the pattern used elsewhere in the test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for external inspection were failing intermittently on ppc64le and
s390x platforms due to UnicodeDecodeError and RuntimeError when reading
from live processes. The _check_exception_status method had no exception
handling at all, and _get_frames_with_retry was missing UnicodeDecodeError
from its suppressed exceptions.
Added TRANSIENT_ERRORS tuple to consolidate the exceptions that can occur
when reading process memory, and RETRY_DELAY constant to unify sleep
intervals. Both affected methods now properly catch all transient errors
and retry, matching the pattern used elsewhere in the test file.