GH-143026: Fix assertion error in executor management. #143104
Merged
+28
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove used _Py_DECREF_NO_DEALLOC function as it is no longer used.
Member
Author
|
Skipping news as the bug never made it to a release |
Fidget-Spinner
approved these changes
Dec 23, 2025
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Ok so my understanding is a pending deletion executor doesn't get re-added twice. Nice.
Fidget-Spinner
approved these changes
Dec 23, 2025
Member
|
Nice! The JIT tests are no longer failing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove used
_Py_DECREF_NO_DEALLOCfunction as it is no longer used._Py_DECREF_NO_DEALLOC#143026