Skip to content

Conversation

@deadlovelll
Copy link

@deadlovelll deadlovelll commented Jan 28, 2026

Always save authkey in BaseProxy.__reduce__() so proxy created with a custom authkey could be picklable.

Fixes gh-139801.

@deadlovelll deadlovelll requested a review from gpshead as a code owner January 28, 2026 19:19
@bedevere-app
Copy link

bedevere-app bot commented Jan 28, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@deadlovelll
Copy link
Author

deadlovelll commented Jan 28, 2026

I'll be glad to see the feedback! Thanks =)

@picnixz
Copy link
Member

picnixz commented Jan 28, 2026

Well.. one feedback I can give without looking at the PR is that tests should not fail, or you should have an idea why it fails, before requesting a review. We can't make the work of fixing the tests ourselves (otherwise we would have worked on the PR directly). So I suggest that you investigate why the tests fail and at least make sure that some tests succeed (at least on Ubuntu).

In the meantime, I'm marking this PR as not ready.

EDIT: I think you need to tackle a less complex issue. This issue is actually related to security and we prefer core developers making changes to security-related issues (the TypeError in the tests hint that we should not pickle some data).

@picnixz picnixz marked this pull request as draft January 28, 2026 19:54
@deadlovelll
Copy link
Author

Well.. one feedback I can give without looking at the PR is that tests should not fail, or you should have an idea why it fails, before requesting a review. We can't make the work of fixing the tests ourselves (otherwise we would have worked on the PR directly). So I suggest that you investigate why the tests fail and at least make sure that some tests succeed (at least on Ubuntu).

In the meantime, I'm marking this PR as not ready.

EDIT: I think you need to tackle a less complex issue. This issue is actually related to security and we prefer core developers making changes to security-related issues (the TypeError in the tests hint that we should not pickle some data).

Thank you! I'll try not to make same mistakes again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiprocessing.managers.BaseProxy can not be unpickled when using a custom authkey

2 participants