GH-144179: Use recorded values to make optimizer more robust #144437
+1,266
−916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add three new symbol kinds * Do not smuggle code object in _PUSH_FRAME operand * Fix small bug in predicate analysis
markshannon
requested review from
Fidget-Spinner,
savannahostrowski and
tomasr8
as code owners
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
You need tests for the new symbolic types in the optimizer_symbols.c as well.
| tier2 op(_GUARD_CODE, (version/2 -- )) { | ||
| PyObject *code = PyStackRef_AsPyObjectBorrow(frame->f_executable); | ||
| EXIT_IF(code == Py_None); | ||
| EXIT_IF(((PyCodeObject *)code)->co_version != version); |
Member
There was a problem hiding this comment.
Why do we need this? Doesn't a _CHECK_VALIIDTY suffice?
| sym->tag = JIT_SYM_RECORDED_VALUE_TAG; | ||
| sym->recorded_value.known_type = true; | ||
| sym->recorded_value.value = value; | ||
| } |
Member
There was a problem hiding this comment.
Why do we not set bottom here and for the one below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.