gh-132132: Upgrade to VS 2026 on Windows tailcall CI#144516
Closed
Fidget-Spinner wants to merge 0 commit intopython:mainfrom
Closed
gh-132132: Upgrade to VS 2026 on Windows tailcall CI#144516Fidget-Spinner wants to merge 0 commit intopython:mainfrom
Fidget-Spinner wants to merge 0 commit intopython:mainfrom
Conversation
hugovk
reviewed
Feb 5, 2026
Comment on lines
2
to
3
| # Pending https://github.com/rhysd/actionlint/issues/533 | ||
| # and https://github.com/rhysd/actionlint/issues/571 |
Member
There was a problem hiding this comment.
Suggested change
| # Pending https://github.com/rhysd/actionlint/issues/533 | |
| # and https://github.com/rhysd/actionlint/issues/571 | |
| # Pending https://github.com/rhysd/actionlint/pull/615 |
.github/actionlint.yaml
Outdated
| # Pending https://github.com/rhysd/actionlint/issues/533 | ||
| # and https://github.com/rhysd/actionlint/issues/571 | ||
| labels: ["windows-11-arm", "macos-15-intel"] | ||
| labels: ["windows-11-arm", "macos-15-intel", "windows-2025-vs2026"] |
Member
There was a problem hiding this comment.
Suggested change
| labels: ["windows-11-arm", "macos-15-intel", "windows-2025-vs2026"] | |
| labels: ["windows-2025-vs2026"] |
Member
|
Hmm, the runner doesn't seem to be available: https://github.com/python/cpython/actions/runs/21721176273/job/62651063296?pr=144516 |
4 tasks
Member
|
Looks like they announced availability prematurely and they'll need to merge actions/runner-images#13635 first. |
Member
|
It's running now and ======================================================================
FAIL: test_verify_call_opcodes (test.test_dtrace.DTraceOptimizedTests.test_verify_call_opcodes)
Ensure our call stack test hits all function call opcodes
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 149, in test_verify_call_opcodes
self.assertEqual(set(), opcodes)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: Items in the second set but not the first:
'CALL_FUNCTION'
'CALL_FUNCTION_KW'And: ======================================================================
FAIL: test_gc (test.test_dtrace.DTraceNormalTests.test_gc)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in normalize_trace_output
result.sort(key=lambda row: int(row[0]))
~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in <lambda>
result.sort(key=lambda row: int(row[0]))
~~~^^^^^^^^
ValueError: invalid literal for int() with base 10: 'dtrace: failed to compile script D:\\a\\cpython\\cpython\\Lib\\test\\dtracedata\\gc.d: line 1: pid provider is not installed on this system'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 152, in test_gc
self.run_case("gc")
~~~~~~~~~~~~~^^^^^^
File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 119, in run_case
actual_output, expected_output = self.backend.run_case(
~~~~~~~~~~~~~~~~~~~~~^
name, optimize_python=self.optimize_python)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 53, in run_case
actual_output = normalize_trace_output(self.trace_python(
script_file=abspath(name + self.EXTENSION),
python_file=abspath(name + ".py"),
optimize_python=optimize_python))
File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 42, in normalize_trace_output
raise AssertionError(
"tracer produced unparsable output:\n{}".format(output)
)
AssertionError: tracer produced unparsable output:
dtrace: failed to compile script D:\a\cpython\cpython\Lib\test\dtracedata\gc.d: line 1: pid provider is not installed on this systemhttps://github.com/python/cpython/actions/runs/21721176273/job/62741886874?pr=144516 |
Member
Author
Member
test_dtrace can be skipped on Windows, yes. |
Member
Author
|
Sorry I realised I opened the PR from the wrong branch. Let me close and re-open another PR |
Member
Author
|
New PR open at #144544 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This save us a lot of CI resources as we don't need to choco install anything now.