Skip to content

gh-132132: Upgrade to VS 2026 on Windows tailcall CI#144516

Closed
Fidget-Spinner wants to merge 0 commit intopython:mainfrom
Fidget-Spinner:main
Closed

gh-132132: Upgrade to VS 2026 on Windows tailcall CI#144516
Fidget-Spinner wants to merge 0 commit intopython:mainfrom
Fidget-Spinner:main

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Feb 5, 2026

This save us a lot of CI resources as we don't need to choco install anything now.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 2 to 3
# Pending https://github.com/rhysd/actionlint/issues/533
# and https://github.com/rhysd/actionlint/issues/571
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Pending https://github.com/rhysd/actionlint/issues/533
# and https://github.com/rhysd/actionlint/issues/571
# Pending https://github.com/rhysd/actionlint/pull/615

# Pending https://github.com/rhysd/actionlint/issues/533
# and https://github.com/rhysd/actionlint/issues/571
labels: ["windows-11-arm", "macos-15-intel"]
labels: ["windows-11-arm", "macos-15-intel", "windows-2025-vs2026"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ["windows-11-arm", "macos-15-intel", "windows-2025-vs2026"]
labels: ["windows-2025-vs2026"]

@hugovk
Copy link
Member

hugovk commented Feb 5, 2026

Hmm, the runner doesn't seem to be available:

x86_64-pc-windows-msvc/msvc
Started 1h 22m 49s ago

Requested labels: windows-2025-vs2026
Job defined at: python/cpython/.github/workflows/tail-call.yml@refs/pull/144516/merge
Waiting for a runner to pick up this job...
Evaluating tail-call.if
Evaluating: success()
Result: true

https://github.com/python/cpython/actions/runs/21721176273/job/62651063296?pr=144516

@hugovk
Copy link
Member

hugovk commented Feb 5, 2026

Looks like they announced availability prematurely and they'll need to merge actions/runner-images#13635 first.

@hugovk
Copy link
Member

hugovk commented Feb 6, 2026

It's running now and test_dtrace is failing, for example:

======================================================================
FAIL: test_verify_call_opcodes (test.test_dtrace.DTraceOptimizedTests.test_verify_call_opcodes)
Ensure our call stack test hits all function call opcodes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 149, in test_verify_call_opcodes
    self.assertEqual(set(), opcodes)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: Items in the second set but not the first:
'CALL_FUNCTION'
'CALL_FUNCTION_KW'

And:

======================================================================
FAIL: test_gc (test.test_dtrace.DTraceNormalTests.test_gc)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in normalize_trace_output
    result.sort(key=lambda row: int(row[0]))
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in <lambda>
    result.sort(key=lambda row: int(row[0]))
                                ~~~^^^^^^^^
ValueError: invalid literal for int() with base 10: 'dtrace: failed to compile script D:\\a\\cpython\\cpython\\Lib\\test\\dtracedata\\gc.d: line 1: pid provider is not installed on this system'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 152, in test_gc
    self.run_case("gc")
    ~~~~~~~~~~~~~^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 119, in run_case
    actual_output, expected_output = self.backend.run_case(
                                     ~~~~~~~~~~~~~~~~~~~~~^
        name, optimize_python=self.optimize_python)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 53, in run_case
    actual_output = normalize_trace_output(self.trace_python(
        script_file=abspath(name + self.EXTENSION),
        python_file=abspath(name + ".py"),
        optimize_python=optimize_python))
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 42, in normalize_trace_output
    raise AssertionError(
        "tracer produced unparsable output:\n{}".format(output)
    )
AssertionError: tracer produced unparsable output:
dtrace: failed to compile script D:\a\cpython\cpython\Lib\test\dtracedata\gc.d: line 1: pid provider is not installed on this system

https://github.com/python/cpython/actions/runs/21721176273/job/62741886874?pr=144516

@Fidget-Spinner
Copy link
Member Author

@hugovk apparently this is a prior known bug for this runner #138744

I suggest we just skip the test on Windows 11?

@vstinner
Copy link
Member

vstinner commented Feb 6, 2026

I suggest we just skip the test on Windows 11?

test_dtrace can be skipped on Windows, yes.

@Fidget-Spinner
Copy link
Member Author

Sorry I realised I opened the PR from the wrong branch. Let me close and re-open another PR

@Fidget-Spinner
Copy link
Member Author

New PR open at #144544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants