gh-141510: Fix test_xpickle failing with introduction of frozendict#144927
Merged
vstinner merged 1 commit intopython:mainfrom Feb 17, 2026
Merged
gh-141510: Fix test_xpickle failing with introduction of frozendict#144927vstinner merged 1 commit intopython:mainfrom
test_xpickle failing with introduction of frozendict#144927vstinner merged 1 commit intopython:mainfrom
Conversation
test_xpickle failing with introduction of frozendicttest_xpickle failing with introduction of frozendict
vstinner
approved these changes
Feb 17, 2026
Member
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I confirm that ./python -m test test_xpickle -u xpickle fails without the change, and pass successfully with the change.
Member
|
Merged, thanks for the fix. |
Member
Author
|
Thanks for the review/merge. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #144878 just yesterday... we should start running this test somewhere.