Skip to content

gh-145557: Check ctypes is available in test.test_external_inspection#145558

Merged
vstinner merged 1 commit intopython:mainfrom
alexmalyshev:external-inspection
Mar 5, 2026
Merged

gh-145557: Check ctypes is available in test.test_external_inspection#145558
vstinner merged 1 commit intopython:mainfrom
alexmalyshev:external-inspection

Conversation

@alexmalyshev
Copy link
Contributor

@alexmalyshev alexmalyshev commented Mar 5, 2026

Currently TestGetStackTrace.test_self_trace_after_ctypes_import() will fail if
the ctypes extension is not built. Make it match test.test_ctypes by skipping
the test in that case.

@python-cla-bot
Copy link

python-cla-bot bot commented Mar 5, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 5, 2026
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Currently TestGetStackTrace.test_self_trace_after_ctypes_import() will fail if
the ctypes extension is not built.  Make it match test.test_ctypes by skipping
the test in that case.
@alexmalyshev alexmalyshev force-pushed the external-inspection branch from d2bc000 to 9f82546 Compare March 5, 2026 18:35
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@vstinner vstinner added skip news needs backport to 3.14 bugs and security fixes labels Mar 5, 2026
@vstinner vstinner enabled auto-merge (squash) March 5, 2026 18:46
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 7232883 into python:main Mar 5, 2026
53 checks passed
@miss-islington-app
Copy link

Thanks @alexmalyshev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2026
pythonGH-145558)

Currently TestGetStackTrace.test_self_trace_after_ctypes_import() will fail if
the _ctypes extension is not built.  Make it match test_ctypes by skipping
the test in that case.
(cherry picked from commit 7232883)

Co-authored-by: Alex Malyshev <lex.malyshev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2026

GH-145565 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 5, 2026
vstinner pushed a commit that referenced this pull request Mar 5, 2026
…on (GH-145558) (#145565)

gh-145557: Check ctypes is available in test_external_inspection (GH-145558)

Currently TestGetStackTrace.test_self_trace_after_ctypes_import() will fail if
the _ctypes extension is not built.  Make it match test_ctypes by skipping
the test in that case.
(cherry picked from commit 7232883)

Co-authored-by: Alex Malyshev <lex.malyshev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants