gh-145623: Fix crashes on uninitialized struct.Struct objects#145624
Merged
corona10 merged 2 commits intopython:mainfrom Mar 7, 2026
Merged
gh-145623: Fix crashes on uninitialized struct.Struct objects#145624corona10 merged 2 commits intopython:mainfrom
corona10 merged 2 commits intopython:mainfrom
Conversation
Add ENSURE_STRUCT_IS_READY() checks to Struct.__sizeof__() and Struct.__repr__() to prevent NULL pointer dereference and invalid memory read when called on a Struct created via __new__() without __init__().
skirpichev
approved these changes
Mar 7, 2026
|
Sorry, @raminfp and @corona10, I could not cleanly backport this to |
|
Sorry, @raminfp and @corona10, I could not cleanly backport this to |
Member
|
@raminfp In my local environment, Python 3.14 and 3.13 have same issue, would you like to create a backport patch for this? |
raminfp
added a commit
to raminfp/cpython
that referenced
this pull request
Mar 7, 2026
|
GH-145630 is a backport of this pull request to the 3.14 branch. |
|
GH-145631 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ENSURE_STRUCT_IS_READY()checks toStruct.__sizeof__()andStruct.__repr__()to prevent crashes when called on uninitializedStructobjects._struct: NULL Pointer Dereference in Struct.__sizeof__() #145623