gh-145876: Fix AttributeError masked during dict unpacking#145877
gh-145876: Fix AttributeError masked during dict unpacking#145877ashm-dev wants to merge 1 commit intopython:mainfrom
Conversation
picnixz
left a comment
There was a problem hiding this comment.
I suspect that this will add an overhead to non-exact dict operations. It's definitely not desirable in this case. In addition, the case is a bit niche IMO. I want to discuss this on the issue first so I'm going to close it for now.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
Summary
.keysattribute existence before callingPyDict_Update/_PyDict_MergeExinDICT_UPDATEandDICT_MERGEbytecodesAttributeErrorcatch that was masking real errors asTypeError: 'X' object is not a mappingCloses #145876.
.keys()or.__getitem__()during{**mymapping}are incorrectly masked #145876