gh-126910: Verify that JIT stencils preserve frame pointer#146524
Merged
Fidget-Spinner merged 11 commits intopython:mainfrom Mar 27, 2026
Merged
gh-126910: Verify that JIT stencils preserve frame pointer#146524Fidget-Spinner merged 11 commits intopython:mainfrom
Fidget-Spinner merged 11 commits intopython:mainfrom
Conversation
Fidget-Spinner
requested review from
brandtbucher,
diegorusso and
savannahostrowski
as code owners
Member
Author
|
Alright! Confirmed all platforms that currently support frame pointers (x64 and AArch64) fail, so this means it does work! |
Fidget-Spinner
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
Member
Author
|
Just an FYI: discussed with Mark on 26 Mar UK time that we should just remove the clever tricks to get the frame address and use a simple approximate one. |
Member
Author
|
Had to partially revert some of #146521 because the current recursion limit/stack overflow detection is working strangely after that with the JIT. Brandt's suggestion to just whack a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a lightweight assembly verifier that the JIT does not clobber the frame pointer.
I verified that without #146521 , this will fail JIT compilation on x86-64. Will use CI to test AArch64.
This is expected to fail JIT CI until that PR lands.