Skip to content

gh-146553: Fix infinite loop in typing.get_type_hints() on circular __wrapped__#146554

Open
raminfp wants to merge 2 commits intopython:mainfrom
raminfp:gh-146553-fix-get-type-hints-wrapped-cycle
Open

gh-146553: Fix infinite loop in typing.get_type_hints() on circular __wrapped__#146554
raminfp wants to merge 2 commits intopython:mainfrom
raminfp:gh-146553-fix-get-type-hints-wrapped-cycle

Conversation

@raminfp
Copy link
Copy Markdown
Contributor

@raminfp raminfp commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

@brianschubert brianschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make sense to lazily import inspect here instead of having two implementations of essentially the same thing? inspect is a heavy import, but if you're calling get_type_hints you're already doing some sort of runtime signature introspection, in which case the import cost may be less of a concern.

@raminfp Please be mindful of https://devguide.python.org/getting-started/generative-ai/. I see you have been warned about relying on LLM generated PRs in the past. If you do decide to use LLMs, please make sure you take the time to scrutinize the output and compare it with the existing code before submitting a PR. In particular, you should try to match the style of the existing code (e.g. don't use _private_names for local variables).

@raminfp
Copy link
Copy Markdown
Contributor Author

raminfp commented Mar 28, 2026

@brianschubert Thank you for the review and for pointing this out. I do use LLM assistance when working on contributions (testing, security check, design and etc), but I wasn't sufficiently familiar with the relevant stdlib methods, specifically inspect.unwrap, which led to re-implementing logic that already exists. I appreciate the feedback, and I'll make sure to do a more thorough review of existing stdlib utilities before submitting patches in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants