gh-146615: Fix error message in method_get for invalid type argument#146634
Open
sunmy2019 wants to merge 5 commits intopython:mainfrom
Open
gh-146615: Fix error message in method_get for invalid type argument#146634sunmy2019 wants to merge 5 commits intopython:mainfrom
sunmy2019 wants to merge 5 commits intopython:mainfrom
Conversation
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please add a test and a NEWS entry.
serhiy-storchaka
added
needs backport to 3.13
Lib/test/test_descr.py
Outdated
| # METH_METHOD|METH_FASTCALL|METH_KEYWORDS is the only flag combination | ||
| # that enters the affected branch in method_get(). | ||
|
|
||
| import xxlimited |
Member
There was a problem hiding this comment.
It could be tested without the use of the optional xxlimited module. For example:
array.array.extend.__get__(array.array('I'), 'not_a_type')
Of course, using METH_METHOD|METH_FASTCALL|METH_KEYWORDS in the implementation of array.array.extend is CPython specific, so you can try several other classes and methods in hope that they are implemented in such way. If none of them raises a TypeError, then skip the test (skipTest()). Or maybe mark the test CPython-only?
Member
Author
There was a problem hiding this comment.
mark the test CPython-only?
I think this is reasonable. This problem only occurs in C modules. It cannot trigger in pure Python code.
I checked
array.array.extend.__get__(array.array('I'), 'not_a_type')will not raise error in Pypy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.