Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29549: Fixes docstring for str.index #147

Closed

Conversation

Projects
None yet
6 participants
@CuriousLearner
Copy link
Contributor

commented Feb 18, 2017

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Feb 18, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@CuriousLearner

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2017

CLA is signed and now visible in my account.

cc @ncoghlan

@zhangyangyu zhangyangyu requested a review from serhiy-storchaka Feb 22, 2017

@serhiy-storchaka

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

See my comment on http://bugs.python.org/issue29549#msg288027.

I do not see much sense in this one change. In any case, it will have to be rewritten. This is far from what is required.

@Mariatta

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

Hi @CuriousLearner . The issue referenced in the BPO is currently assigned to another person. I would suggest that you choose a different issue to work on, one that is not assigned to anyone.
In case it is assigned, please ask first before starting working on it.
Thanks.

@CuriousLearner

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2017

@Mariatta Alright. I apologize for this. I didn't notice this issue was already assigned. Thanks.

@ncoghlan

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

akruis added a commit to akruis/cpython that referenced this pull request Dec 20, 2017

Stackless issue python#147: fix deprecation warnings in Stackless tests
Don't use deprecated functions in the Stackless test suite.

akruis added a commit to akruis/cpython that referenced this pull request Mar 25, 2018

Stackless issue python#147: fix deprecation warnings in Stackless tests
Don't use deprecated functions in the Stackless test suite.
(cherry picked from commit 6c49d91)

akruis added a commit to akruis/cpython that referenced this pull request Jun 19, 2018

Stackless issue python#147: fix deprecation warnings in Stackless tests
Don't use deprecated functions in the Stackless test suite.
(cherry picked from commit 6c49d91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.