Skip to content

bpo-35476: clear error in _imp_create_dynamic_impl #14738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isidentical wants to merge 1 commit into from
Closed

bpo-35476: clear error in _imp_create_dynamic_impl #14738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2249,6 +2249,9 @@ _imp_create_dynamic_impl(PyObject *module, PyObject *spec, PyObject *file)

mod = _PyImport_FindExtensionObject(name, path);
if (mod != NULL || PyErr_Occurred()) {
if (PyErr_Occurred()) {
Copy link
Copy Markdown
Member

@brettcannon brettcannon Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid the overhead of calling PyErr_Occurred(), could you store the result in a variable and check that?

PyErr_Clear();
Copy link
Copy Markdown
Member

@brettcannon brettcannon Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started a discussion over on the issue where if I'm right and swallowing an exception is bad then this clearing of the exception should be removed.

}
Copy link
Copy Markdown
Member

@brettcannon brettcannon Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually won't work because since you cleared out the error but are returning NULL you will trigger a failure in the interpreter for saying there's an exception when one isn't set.

Py_DECREF(name);
Py_DECREF(path);
Py_XINCREF(mod);
Expand Down