[3.14] gh-137814: Fix __qualname__ of __annotate__ functions in the interpreter#148221
Open
JelleZijlstra wants to merge 1 commit intopython:3.14from
Open
[3.14] gh-137814: Fix __qualname__ of __annotate__ functions in the interpreter#148221JelleZijlstra wants to merge 1 commit intopython:3.14from
JelleZijlstra wants to merge 1 commit intopython:3.14from
Conversation
… the interpreter I'd still like to do python#137842 on 3.15+, but that requires changing bytecode and we can't really afford to do that in 3.14. So to fix this in 3.14, let's patch things up in the ceval loop instead. This is safe because the compiler only sets __annotate__ to just-created dedicated annotate functions.
JelleZijlstra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd still like to do #137842 on 3.15+, but that requires changing bytecode and we can't really afford to do that in 3.14. So to fix this in 3.14, let's patch things up in the ceval loop instead.
This is safe because the compiler only sets annotate to just-created dedicated annotate functions.
__annotate__functions generated by CPython for class methods have an incorrect__qualname__#137814