You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removing -fno-plt makes Linux stencils use more direct call relocations and fewer GOT-indirect call sequences. On AArch64 it means CALL26 instead of adrp/ldr/blr GOT calls
This improves code size and some complexity of the JIT stencils. It reduces the amount of GOT-specific patching the JIT has to do.
I had to revert the x86-64 changes as they are more involved and require more investigation. I'm going to create a new issue for changing x86-64 Linux target: #148256
Sorry, didn’t have a chance to look at this yet. What happens if the jump is outside the 26 bit range? The trampolines get used? Were the trampolines being used at all before?
Sorry, didn’t have a chance to look at this yet. What happens if the jump is outside the 26 bit range? The trampolines get used? Were the trampolines being used at all before?
Earlier no trampolines were used at all. Now if a jump is out of range, the trampoline is generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diegorusso
requested review from
brandtbucher and
savannahostrowski
as code owners
Removing
-fno-pltmakes Linux stencils use more direct call relocations and fewer GOT-indirect call sequences. On AArch64 it means CALL26 instead of adrp/ldr/blr GOT callsThis improves code size and some complexity of the JIT stencils. It reduces the amount of GOT-specific patching the JIT has to do.