gh-148211: decompose [_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLINE_BORROW in JIT#148313
Merged
Fidget-Spinner merged 1 commit intopython:mainfrom Apr 10, 2026
Merged
Conversation
NekoAsakura
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
Fidget-Spinner
approved these changes
Apr 9, 2026
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Lines changed: 1040 additions & 1411 deletions
Now that's what I like to see!
| } | ||
| sym_set_const(res, out); | ||
| ADD_OP(_POP_CALL_TWO_LOAD_CONST_INLINE_BORROW, 0, (uintptr_t)out); | ||
| ADD_OP(_POP_CALL_TWO, 0, 0); |
Member
There was a problem hiding this comment.
We should get rid of this into POP_TOP, POP_TOP, POP_TOP_NOP, POP_TOP in the next PR.
Contributor
Author
There was a problem hiding this comment.
I'd like to decompose _POP_TWO_LOAD_CONST_INLINE_BORROW and _INSERT_2_LOAD_CONST_INLINE_BORROW and get shot of _POP_TOP_LOAD_CONST_INLINE(_BORROW) we left in #148230 in the next PR. I'll sort _POP_CALL* into individual pops after that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.