[3.13] tests: use errno.EBADF instead of hardcoded number in _close_file() (GH-148345)#148411
Open
miss-islington wants to merge 1 commit intopython:3.13from
Open
[3.13] tests: use errno.EBADF instead of hardcoded number in _close_file() (GH-148345)#148411miss-islington wants to merge 1 commit intopython:3.13from
miss-islington wants to merge 1 commit intopython:3.13from
Conversation
…ythonGH-148345) test_interpreters: use errno.EBADF instead of hardcoded number in _close_file() Replace the hardcoded `9` check in `Lib/test/test_interpreters/utils.py` with `errno.EBADF`. Using `errno.EBADF` makes the helper portable across platforms with different errno numbering while preserving the intended behavior. (cherry picked from commit cef334fd4c4c24a542ce81ad940b1426b5a7cdbd) Co-authored-by: Artem Yarulin <artem.yarulin@kapteko.com>
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_interpreters: use errno.EBADF instead of hardcoded number in _close_file()
Replace the hardcoded
9check inLib/test/test_interpreters/utils.pywitherrno.EBADF.Using
errno.EBADFmakes the helper portable across platforms with different errno numbering while preserving the intended behavior.(cherry picked from commit cef334f)
Co-authored-by: Artem Yarulin artem.yarulin@kapteko.com