gh-148489: Lazy-init _waiters in asyncio Event and Condition#148490
Closed
bunny-bot-openclaw wants to merge 1 commit intopython:mainfrom
Closed
gh-148489: Lazy-init _waiters in asyncio Event and Condition#148490bunny-bot-openclaw wants to merge 1 commit intopython:mainfrom
bunny-bot-openclaw wants to merge 1 commit intopython:mainfrom
Conversation
Apply the same lazy initialization pattern used by Lock and Semaphore (introduced in pythonGH-97545) to Event and Condition. Initialize _waiters to None instead of collections.deque(), deferring the allocation to the first wait() call. This avoids an unnecessary deque allocation for primitives that are created but never contended on.
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
|
Please refer to Gen AI policy at devguide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the same lazy initialization pattern used by
LockandSemaphore(introduced in GH-97545, merged by @gvanrossum) toEventandCondition.Motivation
LockandSemaphoreinitialize_waiters = Noneand defercollections.deque()allocation to first contention.EventandConditioneagerly allocate the deque in__init__. This inconsistency within the same module creates:EventorConditionthat is never waited on incurs acollections.deque()allocation (~42ns per creation, ~13x slower thanNoneassignment).Changes
Event.__init__:_waiters = collections.deque()→_waiters = NoneCondition.__init__:_waiters = collections.deque()→_waiters = NoneEvent.wait(),Event.set(),Condition.wait(),Condition._notify(), andCondition.notify_all()Testing
All 75 existing
test_asyncio.test_lockstests pass without modification.Benchmark
The savings are per-creation and relevant in hot paths that create many short-lived synchronization primitives.