gh-148508: Add resilience to SSL preauth tests on iOS#148536
Merged
freakboy3742 merged 1 commit intopython:mainfrom Apr 14, 2026
Merged
gh-148508: Add resilience to SSL preauth tests on iOS#148536freakboy3742 merged 1 commit intopython:mainfrom
freakboy3742 merged 1 commit intopython:mainfrom
Conversation
freakboy3742
added
needs backport to 3.13
Contributor
Author
|
Tagging @vstinner for review on this since you added the "non_linux_skip_if_other_okay_error" handling. |
Contributor
Author
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 37b278f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148536%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
gpshead
approved these changes
Apr 14, 2026
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
could use a (a|b) regex instead, works either way. this is readable.
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 14, 2026
…-148536) Adds handling for a test case seen in the iOS SSL tests where an SSL connection fails to handshake correctly. (cherry picked from commit c40e8b016a90820e4d799922903b90a505ffaf55) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
|
GH-148539 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 14, 2026
|
GH-148540 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_servertest fails intermittently on the iOS buildbot because an SSL error doesn't raise the expected TLS handshake error.This test already has an escape clause that allows a skip under certain error conditions (raising a ConnectionError, an OSError, or an SSL error with "wrong version number"). Running locally, I reliably hit the OSError handling case; the buildbot also hits the OSError case most of the time, but sometimes it raises SSLError with "[SSL: RECORD_LAYER_FAILURE] record layer failure".
This adds a check for "record layer failure" as an additional failure mode that will be accepted.