Skip to content

gh-148552: Document the loop argument in ensure_future() method#148553

Open
manoj-km24 wants to merge 1 commit intopython:mainfrom
manoj-km24:document-loop-parameter-in-asyncio-future
Open

gh-148552: Document the loop argument in ensure_future() method#148553
manoj-km24 wants to merge 1 commit intopython:mainfrom
manoj-km24:document-loop-parameter-in-asyncio-future

Conversation

@manoj-km24
Copy link
Copy Markdown

@manoj-km24 manoj-km24 commented Apr 14, 2026

Document loop argument in Doc/library/asyncio-future.rst under the ensure_future() method.


📚 Documentation preview 📚: https://cpython-previews--148553.org.readthedocs.build/

Copy link
Copy Markdown
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it is necessary to document it only in one function. Just document it at the toplevel of the module somehow brcause it is not the only function taking n optionsal loop.

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 14, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants