Skip to content

gh-148557: Makefile.pre.in: use em-config for trampoline clang#148556

Open
clementperon wants to merge 1 commit intopython:mainfrom
clementperon:patch-1
Open

gh-148557: Makefile.pre.in: use em-config for trampoline clang#148556
clementperon wants to merge 1 commit intopython:mainfrom
clementperon:patch-1

Conversation

@clementperon
Copy link
Copy Markdown

@clementperon clementperon commented Apr 14, 2026

When CC is wrapped by ccache, the Emscripten trampoline rule cannot derive the matching clang path by treating CC as a single executable path. Query the active LLVM toolchain path with em-config instead.

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Apr 14, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 14, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@clementperon clementperon changed the title Makefile.pre.in: use em-config for trampoline clang gh-148557: Makefile.pre.in: use em-config for trampoline clang Apr 14, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 14, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

When CC is wrapped by ccache, the Emscripten trampoline rule cannot derive the
matching clang path by treating CC as a single executable path. Query the active
LLVM toolchain path with em-config instead.
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 14, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@emmatyping
Copy link
Copy Markdown
Member

!buildbot Emscripten

@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @emmatyping for commit 3a54dd2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148556%2Fmerge

The command will test the builders whose names match following regular expression: Emscripten

The builders matched are:

  • WASM Emscripten PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants