Skip to content

gh-148638: Parse PYTHON_LLTRACE/PYTHON_OPT_DEBUG as integer #148636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StepfenShawn wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

gh-148638: Parse PYTHON_LLTRACE/PYTHON_OPT_DEBUG as integer #148636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c7ac3
Parse PYTHON_LLTRACE/PYTHON_OPT_DEBUG as integers
StepfenShawn Apr 16, 2026
663659e
Parse PYTHON_LLTRACE as an integer
StepfenShawn Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Python/ceval.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ maybe_lltrace_resume_frame(_PyInterpreterFrame *frame, PyObject *globals)
// Can also be controlled by environment variable
char *python_lltrace = Py_GETENV("PYTHON_LLTRACE");
if (python_lltrace != NULL && *python_lltrace >= '0') {
lltrace = *python_lltrace - '0'; // TODO: Parse an int and all that
lltrace = atoi(python_lltrace);
}
}
if (lltrace >= 5) {
Expand Down
6 changes: 3 additions & 3 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ _PyJit_translate_single_bytecode_to_trace(
char *python_lltrace = Py_GETENV("PYTHON_LLTRACE");
int lltrace = 0;
if (python_lltrace != NULL && *python_lltrace >= '0') {
lltrace = *python_lltrace - '0'; // TODO: Parse an int and all that
lltrace = atoi(python_lltrace);
}
#endif
_PyThreadStateImpl *_tstate = (_PyThreadStateImpl *)tstate;
Expand Down Expand Up @@ -1033,7 +1033,7 @@ _PyJit_TryInitializeTracing(
char *python_lltrace = Py_GETENV("PYTHON_LLTRACE");
int lltrace = 0;
if (python_lltrace != NULL && *python_lltrace >= '0') {
lltrace = *python_lltrace - '0'; // TODO: Parse an int and all that
lltrace = atoi(python_lltrace);
}
DPRINTF(2,
"Tracing %s (%s:%d) at byte offset %d at chain depth %d\n",
Expand Down Expand Up @@ -1433,7 +1433,7 @@ make_executor_from_uops(_PyThreadStateImpl *tstate, _PyUOpInstruction *buffer, i
char *python_lltrace = Py_GETENV("PYTHON_LLTRACE");
int lltrace = 0;
if (python_lltrace != NULL && *python_lltrace >= '0') {
lltrace = *python_lltrace - '0'; // TODO: Parse an int and all that
lltrace = atoi(python_lltrace);
}
if (lltrace >= 2) {
printf("Optimized trace (length %d):\n", length);
Expand Down
2 changes: 1 addition & 1 deletion Python/optimizer_analysis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
char *uop_debug = Py_GETENV(DEBUG_ENV);
int lltrace = 0;
if (uop_debug != NULL && *uop_debug >= '0') {
lltrace = *uop_debug - '0'; // TODO: Parse an int and all that
lltrace = atoi(uop_debug);
}
return lltrace;
}
Expand Down
2 changes: 1 addition & 1 deletion Python/optimizer_symbols.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ static inline int get_lltrace(void) {
char *uop_debug = Py_GETENV("PYTHON_OPT_DEBUG");
int lltrace = 0;
if (uop_debug != NULL && *uop_debug >= '0') {
lltrace = *uop_debug - '0'; // TODO: Parse an int and all that
lltrace = atoi(uop_debug);
}
return lltrace;
}
Expand Down
Loading