gh-148242: Partial restoration of the historical behavior of defaultdict, without losing thread safety#148881
Open
Changaco wants to merge 7 commits intopython:mainfrom
Open
gh-148242: Partial restoration of the historical behavior of defaultdict, without losing thread safety#148881Changaco wants to merge 7 commits intopython:mainfrom
defaultdict, without losing thread safety#148881Changaco wants to merge 7 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another possible solution to #148242. It breaks some existing code, but not quietly, and it has the advantage of refining the design of the
defaultdictclass a little.Changes to the Python stdlib:
defaultdict.__missing__method is dropped, replaced by a new thread-safedefaultdict.__getitem__.importlib.metadata._collections.FreezableDefaultDictclass is dropped. It could be fixed instead, but it looks fundamentally problematic to me, and unless I missed something it isn't actually needed, so I removed it.Change to the private C API: the static
dict_unhashable_typefunction becomes the exposed_Py_dict_unhashable_type.Alternatives:
defaultdict.__missing__method (gh-148242: Full restoration of the historical behavior ofdefaultdict, without losing thread safety #148880)defaultdict.__missing__method__missing__methods entirely📚 Documentation preview 📚: https://cpython-previews--148881.org.readthedocs.build/