fix: accept raw UUID strings as --namespace argument in uuid CLI (gh-148740)#148939
Closed
Jah-yee wants to merge 2 commits intopython:mainfrom
Closed
fix: accept raw UUID strings as --namespace argument in uuid CLI (gh-148740)#148939Jah-yee wants to merge 2 commits intopython:mainfrom
Jah-yee wants to merge 2 commits intopython:mainfrom
Conversation
On Windows, sysconfig.get_platform() checks for 'amd64' in sys.version to detect 64-bit builds. However, sys.version can be truncated (e.g., ~100 chars on clang builds), causing 'amd64' to be missing and returning 'win32' incorrectly. This fix adds sys.maxsize > 2**32 as a fallback check, which is reliable even when sys.version is truncated. Also reorders arm64 check before arm32 for proper precedence. Fixes: python#145410
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Please stop opening a PR if there is already one addressing the issue |
Member
|
@python/organization-owners Please will you block @Jah-yee? They're repeatedly opening low quality PRs and ignoring feedback. https://github.com/python/cpython/pulls?q=is%3Apr+is%3Aclosed+author%3AJah-yee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
This PR fixes the uuid CLI to accept raw UUID strings as the
--namespaceargument foruuid3/uuid5operations.Previously, the CLI only accepted predefined namespace names (
@dns,@url,@oid,@x500). Users could not specify a custom namespace UUID directly from the command line.Fixes #148740.
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithRoof