gh-148252: Avoid overflow in _remote_debugging binary reader bounds checks#148972
Open
maurycy wants to merge 3 commits intopython:mainfrom
Open
gh-148252: Avoid overflow in _remote_debugging binary reader bounds checks#148972maurycy wants to merge 3 commits intopython:mainfrom
_remote_debugging binary reader bounds checks#148972maurycy wants to merge 3 commits intopython:mainfrom
Conversation
maurycy
commented
Apr 24, 2026
|
|
||
| /* File structure sizes */ | ||
| #define FILE_FOOTER_SIZE 32 | ||
| #define SAMPLE_RECORD_HEADER_SIZE (sizeof(uint64_t) + sizeof(uint32_t) + 1) |
Contributor
Author
There was a problem hiding this comment.
There's already SAMPLE_HEADER_FIXED_SIZE:
but it's hard-coded 13. Maybe it should be changed to this addition?
grep for 13 yields more results:
- https://github.com/python/cpython/blob/665b7dfcfa2/Modules/_remote_debugging/binary_io_writer.c#L656
- https://github.com/python/cpython/blob/665b7dfcfa2/Modules/_remote_debugging/binary_io_writer.c#L657
- https://github.com/python/cpython/blob/665b7dfcfa2/Modules/_remote_debugging/binary_io_reader.c#L979
It looks that there's opportunity to move it to binary_io.h. Makes sense, @pablogsal ?
maurycy
changed the title
_remote_debugging binary reader bound checks_remote_debugging binary reader bounds checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think a test makes sense; it'd fail only on 32-bit machines.
More details: