gh-149117: Set ImportError.name on errors from runpy.run_module/run_path#149159
Open
mattwang44 wants to merge 1 commit intopython:mainfrom
Open
gh-149117: Set ImportError.name on errors from runpy.run_module/run_path#149159mattwang44 wants to merge 1 commit intopython:mainfrom
ImportError.name on errors from runpy.run_module/run_path#149159mattwang44 wants to merge 1 commit intopython:mainfrom
Conversation
runpy.run_module() and runpy.run_path() now set the `name` attribute of the ImportError they raise to the requested module name, matching the behaviour of a regular import statement (previously `name` was always `None`, which broke introspection). The `name=` kwarg is gated on `issubclass(error, ImportError)` because `_get_module_details()` is also used by `_run_module_as_main()` with a private `_Error` sentinel class. `_Error` does not subclass ImportError, and `BaseException.__init__` rejects unknown kwargs at the C level, so passing `name=` unconditionally would break the `python -m foo` codepath.
Documentation build overview
5 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runpy.run_module()andrunpy.run_path()previously raisedImportErrorwithname=None. They now set name to the requested module name, matching a regular import.The
name= kwargis gated onissubclass(error, ImportError)so the private_Errorsentinel used by_run_module_as_main()is unaffected.runpy.run_modulefor a non-existent module raises anImportErrorwithoutnameset toNone#149117