Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/random.py
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,12 @@ def binomialvariate(self, n=1, p=0.5):
if not c:
return x
while True:
y += _floor(_log2(random()) / c) + 1
try:
y += _floor(_log2(random()) / c) + 1
# The random() function can return 0.0, which causes log2(0.0) to raise a ValueError.
# See https://github.com/python/cpython/issue/149221
except ValueError:
continue
if y > n:
Comment thread
lighting9999 marked this conversation as resolved.
return x
x += 1
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_random.py
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,12 @@ def test_avg_std(self):
msg='%s%r' % (variate.__name__, args))
self.assertAlmostEqual(s2/(N-1), sigmasqrd, places=2,
msg='%s%r' % (variate.__name__, args))
def test_binomialvariate_log_zero(self):
# gh-149222: Variety random() return 0.0 no input Error
with unittest.mock.patch.object(random.Random, 'random', return_value=0.0):
result = random.binomialvariate(10, 0.5)
self.assertIsInstance(result, int)
self.assertIn(result, range(11))

def test_constant(self):
g = random.Random()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Catch rare math domain error for :func:`random.binomialvariate`.