Skip to content

gh-149351: Avoid possible broken macOS framework install names when DESTDIR is specified during builds#149352

Merged
ned-deily merged 3 commits intopython:mainfrom
ned-deily:gh-149351-macos-framework-DESTDIR
May 4, 2026
Merged

gh-149351: Avoid possible broken macOS framework install names when DESTDIR is specified during builds#149352
ned-deily merged 3 commits intopython:mainfrom
ned-deily:gh-149351-macos-framework-DESTDIR

Conversation

@ned-deily
Copy link
Copy Markdown
Member

@ned-deily ned-deily commented May 4, 2026 •
edited by bedevere-app Bot
Loading

ned-deily added 3 commits May 4, 2026 03:36
@ned-deily
Do not use DESTDIR in macOS framework install_name.
a137069
@ned-deily
Merge remote-tracking branch 'upstream/main' into gh-xxxxx-macos-fram…
6849ed6 
…ework-install-name-destdir
@ned-deily
pythongh-149351: macOS framework install breakage with DESTDIR
dc7c978 
Avoid potentially creating an incorrect macOS framework install name
when DESTDIR is specified during builds.
@ned-deily ned-deily requested a review from emmatyping as a code owner May 4, 2026 10:22
@ned-deily ned-deily added build The build process and cross-build needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 4, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2026
Closed
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 4, 2026

Documentation build overview

📚 cpython-previews | 🛠️ Build #32524211 | 📁 Comparing dc7c978 against main (246fe14)

  🔍 Preview build  

8 files changed · ± 8 modified

± Modified

@ned-deily ned-deily merged commit 1504bd6 into python:main May 4, 2026
55 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 4, 2026

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 4, 2026

GH-149354 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 4, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 4, 2026

GH-149355 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 4, 2026
ned-deily added a commit that referenced this pull request May 4, 2026
@miss-islington @ned-deily
[3.13] gh-149351: Avoid possible broken macOS framework install names…
7f9236c 
… when DESTDIR is specified during builds (GH-149352) (#149355)

(cherry picked from commit 1504bd6)

Co-authored-by: Ned Deily <nad@python.org>
ned-deily added a commit that referenced this pull request May 4, 2026
@miss-islington @ned-deily
[3.14] gh-149351: Avoid possible broken macOS framework install names…
0c89d36 
… when DESTDIR is specified during builds (GH-149352) (#149354)

(cherry picked from commit 1504bd6)

Co-authored-by: Ned Deily <nad@python.org>
@ned-deily ned-deily deleted the gh-149351-macos-framework-DESTDIR branch May 4, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

build The build process and cross-build OS-mac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ned-deily